Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bolivia national shields #1172

Merged
merged 3 commits into from
Nov 30, 2024
Merged

Add Bolivia national shields #1172

merged 3 commits into from
Nov 30, 2024

Conversation

whubsch
Copy link
Contributor

@whubsch whubsch commented Nov 26, 2024

This pull requests adds road shields for Bolivia's national route network. I can't find any evidence that these shields are used on the ground, but they are used in cartographic representations of the road network. National legislation also outlines designs for departmental and municipal route shields (see below), but I can't find any evidence that those are used in any context.

I've chosen just to reuse the green US interstate business route shield for simplicity's sake.

Screenshot 2024-10-15 at 5 55 50 AM

localhost link
Screenshot 2024-11-26 at 6 10 18 AM

departmental map of Oruro
Screenshot 2024-11-26 at 6 10 29 AM

@quincylvania
Copy link
Contributor

It seems like the US route shield would be a better fit than the interstate shield? There is a function to set the color without adding another sprite.

Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I agree that a badge shield (like the ones used in the US Numbered Highway System) is the right style for this network.

src/js/shield_defs.js Outdated Show resolved Hide resolved
@whubsch
Copy link
Contributor Author

whubsch commented Nov 30, 2024

Thanks for the suggestions! The latest commit should use the generic badgeShieldCrossbar icon.

Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution.

@ZeLonewolf ZeLonewolf merged commit cfc7d48 into osm-americana:main Nov 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants