Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace National Historic Trail shields with triangular color swatches #1120

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

1ec5
Copy link
Member

@1ec5 1ec5 commented Jul 7, 2024

For compliance reasons, the shields introduced in #1115, #1116, and #1117 have been replaced with simple color swatches. Each color swatch is in the shape of a Reuleaux triangle, a shape that is common to many recreational trails, including U.S. Bicycle Routes. The colors continue to correspond to the primary color associated with each trail.

@1ec5 1ec5 added the shields label Jul 7, 2024
@1ec5 1ec5 self-assigned this Jul 7, 2024
@1ec5 1ec5 requested a review from ZeLonewolf July 7, 2024 06:09
@quincylvania
Copy link
Contributor

I'm afraid using plain shields for NHTs would be too confusing. A few of the NHTs are overlapping, so users would need to refer to a legend and be able to distinguish between similar colors to tell which is which. I suggest either making our own designs or removing these entirely until we figure out if we can use the official emblems.

@1ec5
Copy link
Member Author

1ec5 commented Jul 7, 2024

These shields do appear in the legend, and I’ve seen maps that take the same approach to simplifying the shields. But if the concern is about potential color conflicts or colorblindness issues, I suppose we could stick a monogram inside each shield.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this fixes a path issue in the original image that had a bit of blue showing through on the other side of the white ring.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dark blue intentionally overlaps the white part slightly, as per the original shield.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to this itty-bitty portion, which admittedly is too small to show up at 1×:

A light blue, triangular gap between the white and black rings.

Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary pause until we figure out what's permitted.

@quincylvania
Copy link
Contributor

Yeah, I guess a solid color is better than nothing for now :)

@1ec5 1ec5 merged commit b632dac into main Jul 7, 2024
6 checks passed
@1ec5 1ec5 deleted the 1ec5-nht-color-swatch branch July 7, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants