Make dedicated pill shape function #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claysmalley
added
enhancement
claysmalley
reviewed
May 18, 2024
I think it's generally useful and more readable in the ShieldJSON to have the shield definition be able to specify common shapes by name, particularly when they can consume defaults (in this case, corner radii). I confess that I don't fully understand @1ec5's vision for shield definition re-usability, but I see value in a slightly richer dictionary of shield shapes being more extendable down the line. |
claysmalley
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds "pill" as a first-class shape that a shield style can specify. Behind the scenes in the shield library, it still just invoking roundedRectangle, but this allows the shield style definition to not have to do the hack of specifying a pill by declaring a rounded rectangle with a large radius. This removes the hack mentioned in #1062 for taginfo and saves a few bytes of ShieldJSON.
I anticipate doing the same job for circle and homePlate shapes.