Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shield for Inner Loop, Rochester, NY #1068

Merged
merged 11 commits into from
Jun 3, 2024

Conversation

claysmalley
Copy link
Member

@claysmalley claysmalley commented May 17, 2024

The Inner Loop of Rochester, New York has an idiosyncratic shield: a Bus Carrell-style white trapezoid with rounded corners, with the black text "INNER LOOP" (example 1, example 2).

For the shield, I chose to omit the "INNER" and use just the text "LOOP", as there is no other loop route with similar signage in Rochester (the Outer Loop is instead signed as a sequence of Interstate and State routes). I considered "IL" as well, but I would expect that to be less intuitive.

Untitled

image

@jleedev
Copy link
Member

jleedev commented May 17, 2024

I think the orange color is more proper; while it's sometimes in white I see that as akin to the Pennsylvania Turnpike signs sometimes being in white simply to contrast with a green background (when on guide signs vs standalone). It's also careening towards being a historical object so I expect the signage in its current state is pretty much "what you see is what you get".

@claysmalley
Copy link
Member Author

I think the orange color is more proper; while it's sometimes in white I see that as akin to the Pennsylvania Turnpike signs sometimes being in white simply to contrast with a green background (when on guide signs vs standalone).

While it may have been historically signed in orange, I couldn't find any extant examples of this color scheme on street-level imagery. Even the standalone signs are black-and-white, despite the lack of a green background.

@ZeLonewolf
Copy link
Member

Wondering if it would be a little nicer to vertically center the LOOP text, perhaps with a shallower angle on the sides?

src/js/shield_defs.js Outdated Show resolved Hide resolved
@jleedev
Copy link
Member

jleedev commented May 17, 2024

Street View at the (checks notes) Southern terminus, East Main Street.

Sep 2014: Orange https://maps.app.goo.gl/rsUnk4REQr6Mci9b8
Nov 2015: White https://maps.app.goo.gl/V8BgvAg7VWvMLrrZ8

White shield SGTM.

@ZeLonewolf
Copy link
Member

Just for kicks, I tried evening out the top and bottom padding for trapezoidDownShield to 3px each instead of 2px/4px:

image

@claysmalley
Copy link
Member Author

Padding values adjusted to vertically center the text.

Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
image

@claysmalley claysmalley merged commit 975c7b1 into main Jun 3, 2024
6 checks passed
@claysmalley claysmalley deleted the clay-shields-us-ny-innerloop branch June 3, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants