add Mississippi Scenic Route shields #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
approved these changes
Apr 21, 2024
| @@ -1424,6 +1424,11 @@ export function loadShields() { | |||
|
|
|||
| // Mississippi | |||
| shields["US:MS"] = ovalShield(Color.shields.white, Color.shields.black); | |||
| shields["US:MS:Scenic"] = banneredShield( | |||
| ovalShield(Color.shields.white, Color.shields.blue), | |||
| ["SCEN"], | |||
There was a problem hiding this comment.
The banner is also appropriate because there’s always a “SCENIC ROUTE” banner over the shield in the real world.
“SCEN” isn’t the most intuitive abbreviation. Maybe separately we could try to accommodate longer banner text by reducing the pitch or squishing the text horizontally. That could let us spell out “TRUCK” too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenic Routes of Mississippi have shields based on the State Route design, but blue instead of black, and with a "Scenic" banner.
The "SCEN" banner chosen here could potentially be omitted, but I don't think the blue and black contrast well enough to make the distinction clear without it.
example