Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add library icon #1014

Merged
merged 10 commits into from
Jan 21, 2024
Merged

Add library icon #1014

merged 10 commits into from
Jan 21, 2024

Conversation

wmisener
Copy link
Collaborator

Fixes #821, and makes progress on #435 and #692. Adds an icon for libraries: poi_library
Based on feedback in #821, I riffed off the MUTCD I4-1 sign, which depicts a person reading and should be highly recognizable to an American audience.

I'd be open to an approach that uses a lone book symbol as well.

Went with blue coloring, based on discussions like this and others. I think there's an argument to be made that libraries also fit the definition of "Attraction: places where people go for entertainment, leisure, or curiosity", which would be brown, but "community anchor"/"infrastructure" is probably more in line with current style symbology.

Previews:
UCLA (localhost link)
Screen Shot 2023-12-21 at 7 05 24 AM

Gallup, NM (localhost link)
Screen Shot 2023-12-21 at 7 29 51 AM

New York, NY (localhost link)
Screen Shot 2023-12-21 at 7 33 56 AM

Legend:
Screen Shot 2023-12-21 at 7 44 16 AM

@wmisener
Copy link
Collaborator Author

Based on feedback on Slack, a few variants/concepts:
A fatter (more well-rounded?) person in the MUTCD-style icon: poi_library_fatman
Screen Shot 2023-12-21 at 8 22 17 PM

An upright, cracked-open book, similar to the NPS bookstore symbol: poi_library_uprightbook
Screen Shot 2023-12-21 at 8 28 30 PM

An open book, similar to the Carto symbol: poi_library_openbook
Screen Shot 2023-12-21 at 8 36 14 PM

I think any of these concepts would work well! The latter two do have the advantage that the same symbol in the consumer color could easily be reused for bookstores.

@claysmalley
Copy link
Member

I like the NPS bookstore icon. It clearly represents a book (which is hard to discern in the MUTCD icon, IMO), and it looks good in context with other icons. And of course, bonus points for potential reuse in a different color for bookstores.

@ZeLonewolf ZeLonewolf mentioned this pull request Dec 23, 2023
@ZeLonewolf
Copy link
Member

Please add location 17/40.753326/-73.982224 to test/sample_locations.json

@wmisener
Copy link
Collaborator Author

wmisener commented Jan 1, 2024

Done, and I updated the icon in the PR to have the upright/NPS-style book icon for libraries. There was consensus on Slack that this icon would be great for bookstores, which I'll do in a separate PR, and some discussion on whether it would be better to use the same icon or slightly different icons for bookstores and libraries. I'm definitely team same-icon, as I think the style is much more intuitive and coherent that way. But I'm open to other opinions.

Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for working on this.

@ZeLonewolf ZeLonewolf merged commit d79a6d1 into osm-americana:main Jan 21, 2024
6 checks passed
@wmisener wmisener deleted the wmisener/library branch February 18, 2024 06:04
@wmisener wmisener mentioned this pull request Feb 18, 2024
@wmisener wmisener mentioned this pull request Jul 19, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request points of interest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render libraries
3 participants