-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add library icon #1014
Add library icon #1014
Conversation
Based on feedback on Slack, a few variants/concepts: An upright, cracked-open book, similar to the NPS bookstore symbol: An open book, similar to the Carto symbol: I think any of these concepts would work well! The latter two do have the advantage that the same symbol in the consumer color could easily be reused for bookstores. |
I like the NPS bookstore icon. It clearly represents a book (which is hard to discern in the MUTCD icon, IMO), and it looks good in context with other icons. And of course, bonus points for potential reuse in a different color for bookstores. |
Please add location 17/40.753326/-73.982224 to test/sample_locations.json |
Done, and I updated the icon in the PR to have the upright/NPS-style book icon for libraries. There was consensus on Slack that this icon would be great for bookstores, which I'll do in a separate PR, and some discussion on whether it would be better to use the same icon or slightly different icons for bookstores and libraries. I'm definitely team same-icon, as I think the style is much more intuitive and coherent that way. But I'm open to other opinions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks for working on this.
Fixes #821, and makes progress on #435 and #692. Adds an icon for libraries:
Based on feedback in #821, I riffed off the MUTCD I4-1 sign, which depicts a person reading and should be highly recognizable to an American audience.
I'd be open to an approach that uses a lone book symbol as well.
Went with blue coloring, based on discussions like this and others. I think there's an argument to be made that libraries also fit the definition of "Attraction: places where people go for entertainment, leisure, or curiosity", which would be brown, but "community anchor"/"infrastructure" is probably more in line with current style symbology.
Previews:
UCLA (localhost link)
Gallup, NM (localhost link)
New York, NY (localhost link)
Legend: