Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generate_samples script to generate firefox and safari screen shots #1008

Merged
merged 8 commits into from
Mar 14, 2024

Conversation

ZeLonewolf
Copy link
Member

This PR adds a new command line parameter to the generate_samples script, which allows it to specify which browser to use. It defaults to Chrome, or you can specify firefox or safari (webkit).

This is a precursor to generating map sample outputs that show shield differences between browsers in the checks.

I generated the below screenshots in chrome, firefox, and safari (webkit) respectively:

historic_us66_oklahoma
historic_us66_oklahoma
historic_us66_oklahoma

@claysmalley claysmalley added enhancement New feature or request build labels Dec 17, 2023
@ZeLonewolf ZeLonewolf merged commit 9aff5d8 into main Mar 14, 2024
6 checks passed
@ZeLonewolf ZeLonewolf deleted the zlw-browser-checks branch March 14, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants