Deploy PR previews #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds deployment of PR previews for the fonts repo, under the folder /pr-fonts/ rather than /pr/ for the main map. It will also remove old PR previews once the branch is merged. This workflow code is largely copied from the openstreetmap-americana repo. This will allow us to test out changes to the font stacks.
This works by copying the built fonts into OSM US's S3 bucket used for americanamap.org assets including the main map's PR previews.
I've added the necessary repository secrets for this to work and created access credentials on the AWS side.
Note that due to github's permissions model, the PR preview will not run until the upload workflow is on the main branch. So we won't fully know if this works until the next PR.