-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Root system documentation #4297
Conversation
6580f81
to
613ff97
Compare
@@ -16,7 +16,7 @@ This part of OSCAR is in an experimental state; please see [Adding new projects | |||
|
|||
Please direct questions about this part of OSCAR to the following people: | |||
* [Lars Göttgens](https://lgoe.li/) | |||
* [Laura Voggesberger](https://www.ruhr-uni-bochum.de/ffm/Lehrstuehle/Lehrstuhl-VI/voggesberger.html) | |||
* [Felix Röhrich](https://www.art.rwth-aachen.de/cms/~xlgua) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While looking through the existing documentation, I noticed that this contact section is a bit outdated.
Is it fine for you (@felix-roehrich) to be listed here (and then similarly after moving things to src in the contact section there)?
In the src/
documentation, I would find it beneficial to have someone more permanent than Felix and me there, and would additionally put @fingolfin (if that's fine for you).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me
613ff97
to
53f2f0e
Compare
This is now ready for review IMO. There are a thousand things that could be changed/improved, but that can be iterated later, even after moving to Previews to the three new pages are linked in the initial comment. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4297 +/- ##
==========================================
+ Coverage 84.50% 84.51% +0.01%
==========================================
Files 644 644
Lines 85606 85685 +79
==========================================
+ Hits 72339 72419 +80
+ Misses 13267 13266 -1
|
9a3f0ae
to
d7664a7
Compare
d7664a7
to
d95ac6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
gentle bump @fingolfin |
Co-authored-by: Felix Röhrich <[email protected]>
f455d6d
to
3b2fd6a
Compare
bb1a027
to
f5ca39c
Compare
The nightly failure is thofma/Hecke.jl#1687. |
@fingolfin could we get this merged even though you didn't have time to look at it in detail? We have some following work in the pipeline and I am a bit scared of potential conflicts (as this PR here touches and moves a lot of stuff). You'll of course be given the opportunity to look through everything here before we move things to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
In preparation for #4263.
cc @felix-roehrich
previews: