Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root system documentation #4297

Merged
merged 20 commits into from
Nov 22, 2024
Merged

Root system documentation #4297

merged 20 commits into from
Nov 22, 2024

Conversation

@lgoettgens lgoettgens added documentation Improvements or additions to documentation WIP NOT ready for merging topic: LieAlgebras labels Nov 11, 2024
@lgoettgens lgoettgens force-pushed the lg/root-system-docs branch 10 times, most recently from 6580f81 to 613ff97 Compare November 12, 2024 15:39
@@ -16,7 +16,7 @@ This part of OSCAR is in an experimental state; please see [Adding new projects

Please direct questions about this part of OSCAR to the following people:
* [Lars Göttgens](https://lgoe.li/)
* [Laura Voggesberger](https://www.ruhr-uni-bochum.de/ffm/Lehrstuehle/Lehrstuhl-VI/voggesberger.html)
* [Felix Röhrich](https://www.art.rwth-aachen.de/cms/~xlgua)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While looking through the existing documentation, I noticed that this contact section is a bit outdated.
Is it fine for you (@felix-roehrich) to be listed here (and then similarly after moving things to src in the contact section there)?
In the src/ documentation, I would find it beneficial to have someone more permanent than Felix and me there, and would additionally put @fingolfin (if that's fine for you).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@lgoettgens
Copy link
Member Author

This is now ready for review IMO. There are a thousand things that could be changed/improved, but that can be iterated later, even after moving to src/.
Please look for straight up wrong statements/typos in the documentation and docstrings. Or if you have suggestions for some changes, I am happy to look at them.

Previews to the three new pages are linked in the initial comment.

@lgoettgens lgoettgens removed the WIP NOT ready for merging label Nov 12, 2024
@lgoettgens lgoettgens marked this pull request as ready for review November 12, 2024 15:45
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 96.07843% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.51%. Comparing base (aa41156) to head (f5ca39c).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
experimental/LieAlgebras/src/RootSystem.jl 95.34% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4297      +/-   ##
==========================================
+ Coverage   84.50%   84.51%   +0.01%     
==========================================
  Files         644      644              
  Lines       85606    85685      +79     
==========================================
+ Hits        72339    72419      +80     
+ Misses      13267    13266       -1     
Files with missing lines Coverage Δ
...imental/BasisLieHighestWeight/src/MainAlgorithm.jl 97.76% <100.00%> (-0.13%) ⬇️
...l/BasisLieHighestWeight/test/MainAlgorithm-test.jl 97.50% <ø> (ø)
experimental/LieAlgebras/src/CartanMatrix.jl 97.29% <100.00%> (-0.02%) ⬇️
experimental/LieAlgebras/src/LieAlgebraIdeal.jl 43.75% <ø> (ø)
experimental/LieAlgebras/src/LieAlgebras.jl 100.00% <ø> (ø)
experimental/LieAlgebras/src/LieSubalgebra.jl 58.71% <ø> (ø)
experimental/LieAlgebras/src/LinearLieAlgebra.jl 90.25% <ø> (ø)
experimental/LieAlgebras/src/Types.jl 96.68% <100.00%> (ø)
experimental/LieAlgebras/src/WeylGroup.jl 90.28% <100.00%> (ø)
experimental/LieAlgebras/test/CartanMatrix-test.jl 100.00% <ø> (ø)
... and 3 more
---- 🚨 Try these New Features:

@lgoettgens lgoettgens force-pushed the lg/root-system-docs branch 2 times, most recently from 9a3f0ae to d7664a7 Compare November 15, 2024 10:54
experimental/LieAlgebras/src/WeylGroup.jl Outdated Show resolved Hide resolved
experimental/LieAlgebras/src/RootSystem.jl Outdated Show resolved Hide resolved
experimental/LieAlgebras/src/RootSystem.jl Outdated Show resolved Hide resolved
experimental/LieAlgebras/src/RootSystem.jl Outdated Show resolved Hide resolved
Copy link
Collaborator

@felix-roehrich felix-roehrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@lgoettgens
Copy link
Member Author

gentle bump @fingolfin

@lgoettgens
Copy link
Member Author

lgoettgens commented Nov 19, 2024

The nightly failure is thofma/Hecke.jl#1687.

@lgoettgens
Copy link
Member Author

@fingolfin could we get this merged even though you didn't have time to look at it in detail? We have some following work in the pipeline and I am a bit scared of potential conflicts (as this PR here touches and moves a lot of stuff). You'll of course be given the opportunity to look through everything here before we move things to src/.

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@fingolfin fingolfin merged commit 3e670f7 into master Nov 22, 2024
57 of 59 checks passed
@fingolfin fingolfin deleted the lg/root-system-docs branch November 22, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation topic: LieAlgebras
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants