Run sass with --trace #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: https://progress.opensuse.org/issues/162311 In case there is an error, e.g. TypeError: String can't be coerced into Integer Use --trace for backtrace. we don't get a line number or the input. Nothing. --trace will hopefully help us find the source of this sporadic error.
Martchus
approved these changes
Jun 17, 2024
|
https://openqa.opensuse.org/tests/4275646#step/openqa_webui/5 still failing because of the |
okurz
requested changes
Jun 17, 2024
Comment on lines
+59
to
+60
| script_run q{perl -pi -wE 's/\Q = (qw(sass -s)/ = (qw(sass -s --trace)/' } . $sass; | ||
| script_run qq{grep "sass -s" $sass}; |
There was a problem hiding this comment.
It's bad practice to use script_run without checking the exit code. How about
Suggested change
| script_run q{perl -pi -wE 's/\Q = (qw(sass -s)/ = (qw(sass -s --trace)/' } . $sass; | |
| script_run qq{grep "sass -s" $sass}; | |
| assert_script_run q{perl -pi -wE 's/\Q = (qw(sass -s)/ = (qw(sass -s --trace)/' } . $sass; | |
| assert_script_run qq{grep "sass -s" $sass}; |
but in general I would prefer if our code can be as simple as possible resembling what users would need to do. This is quite low-level. How about a Makefile target "prepare-assets" or something that is then called here?
Comment on lines
-61
to
+64
| get_log 'cat nohup.out' => 'openqa_nohup_out.txt'; | ||
| upload_logs('nohup.out', log_name => 'openqa_nohup_out.txt'); |
There was a problem hiding this comment.
that looks like it would be better in a separate commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://progress.opensuse.org/issues/162311
In case there is an error, e.g.
we don't get a line number or the input. Nothing.
--trace will hopefully help us find the source of this sporadic error.