Skip to content

Commit

Permalink
all: export remaining manager test helpers
Browse files Browse the repository at this point in the history
  • Loading branch information
@arekkas
Aeneas Rekkas (arekkas) authored and arekkas committed Jun 13, 2017
1 parent 42df3c9 commit df05c35
Show file tree
Hide file tree
Showing 3 changed files with 189 additions and 180 deletions.
181 changes: 3 additions & 178 deletions manager_all_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,136 +13,8 @@ import (
. "github.com/ory/ladon"
. "github.com/ory/ladon/manager/memory"
. "github.com/ory/ladon/manager/sql"
"github.com/pborman/uuid"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

var managerPolicies = []*DefaultPolicy{
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"user", "anonymous"},
Effect: AllowAccess,
Resources: []string{"article", "user"},
Actions: []string{"create", "update"},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{},
Effect: AllowAccess,
Resources: []string{"<article|user>"},
Actions: []string{"view"},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{},
Effect: AllowAccess,
Resources: []string{},
Actions: []string{"view"},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{},
Effect: AllowAccess,
Resources: []string{},
Actions: []string{},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{},
Effect: AllowAccess,
Resources: []string{"foo"},
Actions: []string{},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"foo"},
Effect: AllowAccess,
Resources: []string{"foo"},
Actions: []string{},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"foo"},
Effect: AllowAccess,
Resources: []string{},
Actions: []string{},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Effect: AllowAccess,
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"<peter|max>"},
Effect: DenyAccess,
Resources: []string{"article", "user"},
Actions: []string{"view"},
Conditions: Conditions{
"owner": &EqualsSubjectCondition{},
},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"<user|max|anonymous>", "peter"},
Effect: DenyAccess,
Resources: []string{".*"},
Actions: []string{"disable"},
Conditions: Conditions{
"ip": &CIDRCondition{
CIDR: "1234",
},
"owner": &EqualsSubjectCondition{},
},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"<.*>"},
Effect: AllowAccess,
Resources: []string{"<article|user>"},
Actions: []string{"view"},
Conditions: Conditions{
"ip": &CIDRCondition{
CIDR: "1234",
},
"owner": &EqualsSubjectCondition{},
},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"<us[er]+>"},
Effect: AllowAccess,
Resources: []string{"<article|user>"},
Actions: []string{"view"},
Conditions: Conditions{
"ip": &CIDRCondition{
CIDR: "1234",
},
"owner": &EqualsSubjectCondition{},
},
},
}

var managers = map[string]Manager{}
var migrators = map[string]ManagerMigrator{}

Expand Down Expand Up @@ -195,60 +67,13 @@ func connectMySQL(wg *sync.WaitGroup) {
}

func TestGetErrors(t *testing.T) {
for _, s := range managers {
_, err := s.Get(uuid.New())
assert.Error(t, err)

_, err = s.Get("asdf")
assert.Error(t, err)
for k, s := range managers {
t.Run("manager=" + k, TestHelperGetErrors(s))
}
}

func TestCreateGetDelete(t *testing.T) {
for k, s := range managers {
t.Run(fmt.Sprintf("manager=%s", k), func(t *testing.T) {
for i, c := range managerPolicies {
t.Run(fmt.Sprintf("case=%d/id=%s/type=create", i, c.GetID()), func(t *testing.T) {
_, err := s.Get(c.GetID())
require.Error(t, err)
require.NoError(t, s.Create(c))
})

t.Run(fmt.Sprintf("case=%d/id=%s/type=query", i, c.GetID()), func(t *testing.T) {
get, err := s.Get(c.GetID())
require.NoError(t, err)

AssertPolicyEqual(t, c, get)
})
}

t.Run("type=query-all", func(t *testing.T) {
pols, err := s.GetAll(100, 0)
require.NoError(t, err)
assert.Len(t, pols, len(managerPolicies))

found := map[string]int{}
for _, got := range pols {
for _, expect := range managerPolicies {
if got.GetID() == expect.GetID() {
found[got.GetID()]++
}
}
}

for _, f := range found {
assert.Equal(t, 1, f)
}
})

for i, c := range managerPolicies {
t.Run(fmt.Sprintf("case=%d/id=%s/type=delete", i, c.GetID()), func(t *testing.T) {
assert.NoError(t, s.Delete(c.ID))

_, err := s.Get(c.GetID())
assert.Error(t, err)
})
}
})
t.Run(fmt.Sprintf("manager=%s", k), TestHelperCreateGetDelete(s))
}
}
184 changes: 184 additions & 0 deletions manager_test_helper.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,131 @@ import (
"github.com/stretchr/testify/require"
)

var TestManagerPolicies = []*DefaultPolicy{
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"user", "anonymous"},
Effect: AllowAccess,
Resources: []string{"article", "user"},
Actions: []string{"create", "update"},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{},
Effect: AllowAccess,
Resources: []string{"<article|user>"},
Actions: []string{"view"},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{},
Effect: AllowAccess,
Resources: []string{},
Actions: []string{"view"},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{},
Effect: AllowAccess,
Resources: []string{},
Actions: []string{},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{},
Effect: AllowAccess,
Resources: []string{"foo"},
Actions: []string{},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"foo"},
Effect: AllowAccess,
Resources: []string{"foo"},
Actions: []string{},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"foo"},
Effect: AllowAccess,
Resources: []string{},
Actions: []string{},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Effect: AllowAccess,
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"<peter|max>"},
Effect: DenyAccess,
Resources: []string{"article", "user"},
Actions: []string{"view"},
Conditions: Conditions{
"owner": &EqualsSubjectCondition{},
},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"<user|max|anonymous>", "peter"},
Effect: DenyAccess,
Resources: []string{".*"},
Actions: []string{"disable"},
Conditions: Conditions{
"ip": &CIDRCondition{
CIDR: "1234",
},
"owner": &EqualsSubjectCondition{},
},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"<.*>"},
Effect: AllowAccess,
Resources: []string{"<article|user>"},
Actions: []string{"view"},
Conditions: Conditions{
"ip": &CIDRCondition{
CIDR: "1234",
},
"owner": &EqualsSubjectCondition{},
},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"<us[er]+>"},
Effect: AllowAccess,
Resources: []string{"<article|user>"},
Actions: []string{"view"},
Conditions: Conditions{
"ip": &CIDRCondition{
CIDR: "1234",
},
"owner": &EqualsSubjectCondition{},
},
},
}

var testPolicies = []*DefaultPolicy{
{
ID: uuid.New(),
Expand Down Expand Up @@ -150,3 +275,62 @@ func testEq(a, b []string) error {

return nil
}

func TestHelperGetErrors(s Manager) func (t *testing.T) {
return func (t *testing.T) {
_, err := s.Get(uuid.New())
assert.Error(t, err)

_, err = s.Get("asdf")
assert.Error(t, err)
}
}

func TestHelperCreateGetDelete(s Manager) func (t *testing.T) {
return func (t *testing.T) {

for i, c := range TestManagerPolicies {
t.Run(fmt.Sprintf("case=%d/id=%s/type=create", i, c.GetID()), func(t *testing.T) {
_, err := s.Get(c.GetID())
require.Error(t, err)
require.NoError(t, s.Create(c))
})

t.Run(fmt.Sprintf("case=%d/id=%s/type=query", i, c.GetID()), func(t *testing.T) {
get, err := s.Get(c.GetID())
require.NoError(t, err)

AssertPolicyEqual(t, c, get)
})
}

t.Run("type=query-all", func(t *testing.T) {
pols, err := s.GetAll(100, 0)
require.NoError(t, err)
assert.Len(t, pols, len(TestManagerPolicies))

found := map[string]int{}
for _, got := range pols {
for _, expect := range TestManagerPolicies {
if got.GetID() == expect.GetID() {
found[got.GetID()]++
}
}
}

for _, f := range found {
assert.Equal(t, 1, f)
}
})

for i, c := range TestManagerPolicies {
t.Run(fmt.Sprintf("case=%d/id=%s/type=delete", i, c.GetID()), func(t *testing.T) {
assert.NoError(t, s.Delete(c.ID))

_, err := s.Get(c.GetID())
assert.Error(t, err)
})
}

}
}
Loading

0 comments on commit df05c35

Please sign in to comment.