Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build cross-platform images #357

Merged
merged 5 commits into from
Sep 16, 2024
Merged

feat: build cross-platform images #357

merged 5 commits into from
Sep 16, 2024

Conversation

meysam81
Copy link
Contributor

Related Issue or Design Document

fixes #331

This PR will build cross-platform Docker images that can be run on more than the current linux/amd64.

Here is a successful CI run:

https://app.circleci.com/pipelines/circleci/A6nbzUoyB9CLzi6DLvaBwb/9smwwFNYSRdLYqTVLve6He/13/workflows/2894361c-6b9b-48e5-8e73-641d79753ce4/jobs/23

And here is the result of that CI run, pushing to my personal Docker repository:

https://hub.docker.com/r/meysam81/kratos-selfservice-ui-node/tags

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@meysam81 meysam81 changed the title Meysam/feat/multiplatform docker build feat(docker): build cross-platform images Sep 15, 2024
@meysam81 meysam81 changed the title feat(docker): build cross-platform images feat: build cross-platform images Sep 15, 2024
@aeneasr aeneasr merged commit 8227d16 into ory:master Sep 16, 2024
7 checks passed
@aeneasr
Copy link
Member

aeneasr commented Sep 16, 2024

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@meysam81 meysam81 deleted the meysam/feat/multiplatform-docker-build branch September 16, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross platform docker images (especially linux/arm64)
2 participants