Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: support IMAGE_TAG build variable #335

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
rand := $(shell openssl rand -hex 6)

export IMAGE_TAG := $(if $(IMAGE_TAG),$(IMAGE_TAG),latest)

.PHONY: docker-dev-build
docker-dev-build:
docker build -f ./Dockerfile-dev -t oryd/kratos-selfservice-ui-node:latest .
docker build -f ./Dockerfile-dev -t oryd/kratos-selfservice-ui-node:${IMAGE_TAG} .

.PHONY: docker
docker:
docker build -t oryd/kratos-selfservice-ui-node:latest .
docker build -t oryd/kratos-selfservice-ui-node:${IMAGE_TAG} .

.PHONY: build-sdk
build-sdk:
@@ -34,7 +36,7 @@ publish-sdk: build-sdk

.PHONY: build-sdk-docker
build-sdk-docker: build-sdk
docker build -t oryd/kratos-selfservice-ui-node:latest . --build-arg LINK=true
docker build -t oryd/kratos-selfservice-ui-node:${IMAGE_TAG} . --build-arg LINK=true

.PHONY: clean-sdk
clean-sdk: