Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: forward org ID during login and registration #293

Merged
merged 2 commits into from
Sep 15, 2023
Merged

feat: forward org ID during login and registration #293

merged 2 commits into from
Sep 15, 2023

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Sep 14, 2023 •
edited
Loading

Related Issue or Design Document

ory/kratos#3489

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@hperl
feat(changelog): support auth_type parameter
ef61dfb 
The Facebook OIDC provider now supports an auth_type parameter that
when set to "reauthenticate" will force the user to
reauthenticate (similar to `prompt=login` for other Providers).

Kratos changes: ory/kratos@7aa2e29...fc30304

Signed-off-by: Henning Perl <[email protected]>
@hperl
feat: forward org ID during registration
fb876bb
@hperl hperl requested a review from Benehiko September 14, 2023 16:33
@hperl hperl self-assigned this Sep 14, 2023
@hperl hperl changed the title Hperl/b2bsso feat: forward org ID during registration Sep 14, 2023
@hperl hperl changed the title feat: forward org ID during registration feat: forward org ID during login and registration Sep 14, 2023
Benehiko
Benehiko reviewed Sep 15, 2023
View reviewed changes
Copy link
Contributor

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, would it be possible to link which PR in Kratos this is related to and maybe a description in the PR?

@hperl hperl merged commit b6a02ba into master Sep 15, 2023
7 of 8 checks passed
@hperl hperl deleted the hperl/b2bsso branch September 15, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benehiko Benehiko Benehiko left review comments

@alnr alnr alnr approved these changes

Assignees

@hperl hperl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hperl @alnr @Benehiko