-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update csurf -> csrf-csrf #290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benehiko
force-pushed
the
chore-package-updates
branch
from
September 11, 2023 11:33
e492c92
to
0a1fb89
Compare
Benehiko
commented
Sep 11, 2023
Benehiko
force-pushed
the
chore-package-updates
branch
2 times, most recently
from
September 13, 2023 16:01
d79a0da
to
ce5d0d4
Compare
alnr
reviewed
Sep 14, 2023
alnr
reviewed
Sep 14, 2023
jonas-jonas
reviewed
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good, and I might be able to use this lib as well. Looks like it's very versatile. Also, very nice updates to the README.
Have just a few nits.
Co-authored-by: Arne Luenser <[email protected]>
Co-authored-by: Arne Luenser <[email protected]>
Benehiko
force-pushed
the
chore-package-updates
branch
from
September 15, 2023 12:18
17aea76
to
5934457
Compare
jonas-jonas
reviewed
Sep 15, 2023
aeneasr
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
csurf
withcsrf-csrf
. https://www.npmjs.com/package/csrf-csrfI have also updated the Ory client to the latest version.
Since this is a change in security related packages concerning CSRF protection on the consent endpoint, could you take a look @hperl?
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments