Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user experience improvements and e2e test coverage #321

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Dec 20, 2024

This patch resolves several issues:

  • Adds test IDs to components used by e2e selectors
  • Transports the return URL across flows (login/registration, recovery) and also when restarting flows (this should solve a lot of pain for users running into errors).

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

This patch resolves several issues:

- Adds test IDs to components used by e2e selectors
- Transports the return URL across flows (login/registration, recovery)
@aeneasr aeneasr force-pushed the improve-ux-2 branch 3 times, most recently from 190e6df to 7fa78d2 Compare December 20, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant