-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: user experience improvements and e2e test coverage #321
Conversation
190e6df
to
7fa78d2
Compare
This patch resolves several issues: - Adds test IDs to components used by e2e selectors - Transports the return URL across flows (login/registration, recovery)
1f21254
to
8deedd6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
==========================================
+ Coverage 42.43% 42.80% +0.37%
==========================================
Files 136 138 +2
Lines 2008 2065 +57
Branches 288 303 +15
==========================================
+ Hits 852 884 +32
- Misses 1149 1172 +23
- Partials 7 9 +2
|
packages/elements-react/src/theme/default/components/card/current-identifier-button.tsx
Show resolved
Hide resolved
Also, this change makes the init flow helper available to consumers: #326 wdyt about that? |
The PR here is working for all flows, #326 is not. I recommend just merging this PR as it's been open long enough, and really doesn't change a lot of functionality except for fixing all the holes with e2e tests. #326 did not run against the cloud e2e tests i've been working on, and I don't have enough time to spend to rebase it all. So let's get this one here through, and then we can still apply the missing pieces to #326 and merge those improvements. |
This patch resolves several issues:
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments