Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing eslint to example #313

Merged
merged 1 commit into from
Dec 17, 2024
Merged

chore: add missing eslint to example #313

merged 1 commit into from
Dec 17, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Dec 17, 2024

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ory/elements/blob/main/eslint.config.mjs#L23

Eslint is now managed centrally, not sure this change works. I tried to integrate the Next.js linting into that file for a couple of hours, but gave up as this project is unmaintained anyway.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.73%. Comparing base (ecd5bfd) to head (c0ab382).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #313   +/-   ##
=======================================
  Coverage   43.73%   43.73%           
=======================================
  Files         135      135           
  Lines        1932     1932           
  Branches      279      279           
=======================================
  Hits          845      845           
  Misses       1080     1080           
  Partials        7        7           
Components Coverage Δ
@ory/elements-react 38.14% <ø> (ø)
@ory/nextjs 65.97% <ø> (ø)

Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is happy, so seems to work.

@jonas-jonas jonas-jonas merged commit 071c0ff into main Dec 17, 2024
15 checks passed
@jonas-jonas jonas-jonas deleted the add-eslint branch December 17, 2024 09:51
@aeneasr
Copy link
Member Author

aeneasr commented Dec 17, 2024

It was failing for me prior but maybe because of outdated nom dependencies? This fixed it, but it seemed to work in CI prior. Not sure now... We can probably revert

aeneasr added a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants