Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add page and app router examples #307

Merged
merged 6 commits into from
Dec 17, 2024
Merged

feat: add page and app router examples #307

merged 6 commits into from
Dec 17, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Dec 5, 2024

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@aeneasr aeneasr assigned jonas-jonas and unassigned aeneasr Dec 5, 2024
@aeneasr aeneasr force-pushed the add-examples branch 2 times, most recently from be040eb to b5e252f Compare December 5, 2024 15:25
@aeneasr aeneasr requested a review from jonas-jonas December 5, 2024 15:26
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 24.44444% with 34 lines in your changes missing coverage. Please review.

Project coverage is 43.73%. Comparing base (05a77ff) to head (1cc0625).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
- Coverage   44.05%   43.73%   -0.32%     
==========================================
  Files         131      135       +4     
  Lines        1893     1932      +39     
  Branches      276      279       +3     
==========================================
+ Hits          834      845      +11     
- Misses       1053     1080      +27     
- Partials        6        7       +1     
Components Coverage Δ
@ory/elements-react 38.14% <27.27%> (+0.07%) ⬆️
@ory/nextjs 65.97% <23.52%> (-4.08%) ⬇️

@aeneasr aeneasr force-pushed the add-examples branch 3 times, most recently from 26482dc to 3b8a292 Compare December 5, 2024 17:12
@jonas-jonas jonas-jonas force-pushed the add-examples branch 2 times, most recently from 34e401b to efa9445 Compare December 11, 2024 15:31
@jonas-jonas jonas-jonas force-pushed the add-examples branch 2 times, most recently from bf00cf8 to 9dc6e52 Compare December 13, 2024 12:38
@aeneasr aeneasr merged commit ecd5bfd into main Dec 17, 2024
11 of 13 checks passed
@aeneasr aeneasr deleted the add-examples branch December 17, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants