Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add react-hook form resolver #298

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Nov 27, 2024
@jonas-jonas jonas-jonas force-pushed the jonas-jonas/formResolver branch from 94909e2 to b4248d5 Compare November 27, 2024 06:54
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 59.97%. Comparing base (8a4ddbc) to head (78590ab).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...elements-react/src/components/form/nodes/input.tsx 0.00% 3 Missing ⚠️
...-react/src/theme/default/components/form/label.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
+ Coverage   59.09%   59.97%   +0.88%     
==========================================
  Files          68       69       +1     
  Lines         946      957      +11     
  Branches      133      136       +3     
==========================================
+ Hits          559      574      +15     
+ Misses        381      377       -4     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas force-pushed the jonas-jonas/formResolver branch from b4248d5 to 78590ab Compare November 27, 2024 11:18
@jonas-jonas jonas-jonas merged commit e46f5fd into main Nov 27, 2024
9 of 13 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/formResolver branch November 27, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants