Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oidc linking & unlinking form properties #260

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 58.02%. Comparing base (6cb5150) to head (89b7d50).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...heme/default/components/settings/settings-oidc.tsx 11.11% 8 Missing ⚠️
...-react/src/theme/default/components/form/input.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   58.49%   58.02%   -0.47%     
==========================================
  Files          65       65              
  Lines         812      822      +10     
  Branches      104      105       +1     
==========================================
+ Hits          475      477       +2     
- Misses        332      340       +8     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas merged commit 2a6999f into main Nov 5, 2024
12 of 14 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/settingsFix branch November 5, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant