Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show identifier_first node in card header #215

Merged

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.12%. Comparing base (fa98d7f) to head (65d2156).
Report is 1 commits behind head on jonas-jonas/elementsv1.

Files with missing lines Patch % Lines
...act/src/theme/default/utils/constructCardHeader.ts 94.87% 1 Missing and 1 partial ⚠️
...react/src/theme/default/components/card/header.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           jonas-jonas/elementsv1     #215      +/-   ##
==========================================================
+ Coverage                   41.50%   46.12%   +4.62%     
==========================================================
  Files                          85       86       +1     
  Lines                         812      813       +1     
  Branches                       99      100       +1     
==========================================================
+ Hits                          337      375      +38     
+ Misses                        471      433      -38     
- Partials                        4        5       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas merged commit 3aa5c00 into jonas-jonas/elementsv1 Sep 25, 2024
8 of 12 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/identifierFirstCardHeaderHint branch September 25, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants