Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add two-step login card #211

Merged
merged 26 commits into from
Sep 27, 2024

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Sep 16, 2024
@jonas-jonas jonas-jonas changed the title fix: discard base branch changes feat: add two-step login card Sep 16, 2024
@jonas-jonas jonas-jonas mentioned this pull request Sep 16, 2024
6 tasks
@jonas-jonas jonas-jonas force-pushed the jonas-jonas/elementsv1 branch from 04eb255 to 1700055 Compare September 16, 2024 09:29
@jonas-jonas jonas-jonas force-pushed the feat/elementsImprovementsRebased branch from 8c26081 to 89bd68f Compare September 16, 2024 09:32
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 43.47826% with 65 lines in your changes missing coverage. Please review.

Project coverage is 45.34%. Comparing base (3aa5c00) to head (16590fd).

Files with missing lines Patch % Lines
...ements-react/src/components/card/card-two-step.tsx 28.57% 40 Missing ⚠️
...ages/elements-react/src/components/form/social.tsx 21.42% 11 Missing ⚠️
packages/elements-react/src/util/ui/index.ts 20.00% 8 Missing ⚠️
...ckages/elements-react/src/components/form/form.tsx 0.00% 2 Missing ⚠️
...src/theme/default/components/card/auth-methods.tsx 50.00% 2 Missing ⚠️
...-react/src/theme/default/components/form/input.tsx 0.00% 1 Missing ⚠️
...react/src/theme/default/components/form/social.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           jonas-jonas/elementsv1     #211      +/-   ##
==========================================================
- Coverage                   46.12%   45.34%   -0.79%     
==========================================================
  Files                          86       88       +2     
  Lines                         813      880      +67     
  Branches                      100      114      +14     
==========================================================
+ Hits                          375      399      +24     
- Misses                        433      476      +43     
  Partials                        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mszekiel mszekiel force-pushed the feat/elementsImprovementsRebased branch from 89bd68f to 20c8c3a Compare September 16, 2024 15:51
@mszekiel mszekiel assigned mszekiel and unassigned jonas-jonas Sep 16, 2024
@mszekiel mszekiel force-pushed the feat/elementsImprovementsRebased branch from 20c8c3a to e5a53da Compare September 17, 2024 08:19
@jonas-jonas jonas-jonas force-pushed the jonas-jonas/elementsv1 branch from ff92fa7 to 32ff27e Compare September 17, 2024 11:00
@mszekiel mszekiel force-pushed the feat/elementsImprovementsRebased branch from 6198474 to 2c033ab Compare September 24, 2024 08:29
@jonas-jonas jonas-jonas force-pushed the jonas-jonas/elementsv1 branch from 8befd64 to fa98d7f Compare September 24, 2024 19:30
@jonas-jonas jonas-jonas force-pushed the feat/elementsImprovementsRebased branch from 1f21188 to 651a63f Compare September 25, 2024 18:04
@jonas-jonas jonas-jonas marked this pull request as ready for review September 25, 2024 18:05
@mszekiel mszekiel force-pushed the feat/elementsImprovementsRebased branch from 651a63f to d580317 Compare September 26, 2024 12:01
@jonas-jonas jonas-jonas merged commit 151ebaa into jonas-jonas/elementsv1 Sep 27, 2024
3 checks passed
@jonas-jonas jonas-jonas deleted the feat/elementsImprovementsRebased branch September 27, 2024 14:42
jonas-jonas added a commit that referenced this pull request Oct 16, 2024
jonas-jonas added a commit that referenced this pull request Oct 16, 2024
jonas-jonas added a commit that referenced this pull request Oct 16, 2024
jonas-jonas added a commit that referenced this pull request Oct 16, 2024
jonas-jonas added a commit that referenced this pull request Oct 16, 2024
jonas-jonas added a commit that referenced this pull request Oct 16, 2024
jonas-jonas added a commit that referenced this pull request Oct 16, 2024
jonas-jonas added a commit that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants