Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consent card with custom onSubmit #112

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Benehiko
Copy link
Contributor

@Benehiko Benehiko commented Jul 4, 2023

Related Issue or Design Document

#110

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation within the code base (if appropriate).

Further comments

@davidspek
Copy link

Do the changes in this PR need testing?

@Benehiko
Copy link
Contributor Author

yes, i haven't had time to complete it yet. It still requires a bit more e2e testing to make sure this works properly in the example nextjs application.

@Benehiko Benehiko force-pushed the feat-consent-card-onsubmit branch 2 times, most recently from 0378140 to 2b2bc87 Compare August 28, 2023 11:52
@Benehiko Benehiko force-pushed the feat-consent-card-onsubmit branch from af79bf5 to 6afcf57 Compare October 5, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants