Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom redis client in constructor #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow custom redis client in constructor #15

wants to merge 1 commit into from

Conversation

dirkbonhomme
Copy link

No description provided.

@jamessharp
Copy link
Member

This is a nice idea but is a bit more difficult than it appears at first. Your solution doesn't take into account the functions getMasterFromEndpoint and friends which also use redis directly. I'm sure with a bit of plumbing it could be made to work though.

@dirkbonhomme
Copy link
Author

Alright I'll have a look at how it can be improved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirkbonhomme @jamessharp