clean up

advanced-setup/README.md

@@ -5,6 +5,7 @@ between a DICOM compliant modality and a dicomweb compliant PACS.
 
 This advanced setup includes Keycloak.
 The Orthanc user has permissions only on a specific tag, so that not all the studies are available.
+Of course, this setup is relevant only if the DICOMweb server to query is Orthanc...
 
 # Description
 
@@ -15,9 +16,6 @@ This demo contains the same containers as the sample setup plus:
 
 # Starting the setup
 
-- To start the setup, type: `docker-compose up --build`
-- visit Keycloak admin page, get the client secret and put it in the compose, the restart the setup
+- To start the setup, type: `docker-compose up -d --build`
+- visit Keycloak admin page, get the client secret and put it in the compose, then restart the setup
 - still in Keycloak admin page, add an `api-key` attribute (and value) for the user from the proxy 
-
-# demo
-TODO

proxy.py

@@ -140,8 +140,6 @@ def OnFind(answers, query, issuerAet, calledAet):
         answers.FindAddAnswer(orthanc.CreateDicom(
             json.dumps(dicomTagsList), None, orthanc.CreateDicomFlags.NONE))
 
-# todo: test scenario
-
 def WadoRs(request, dicomwebServerAlias = None):
 
     # Let's build the payload
@@ -202,8 +200,6 @@ def GetOrthancAliasFromAET(AET):
     raise Exception('It seems that the modality issuing the original DICOM query is not registered in the Proxy config!')
 
 def OnMove(**request):
-    print("entering in move------------------")
-    time.sleep(18)
     # fetch the resource from the dicomweb server
     if request["SourceAET"] in {None, ''}:
         raise Exception('The DICOM query does not contain a value for the SourceAET, unable to process it!')

simple-setup/README.md

@@ -15,7 +15,7 @@ the modality to dicomweb queries. It also converts the dicomweb replies from the
 
 # Starting the setup
 
-To start the setup, type: `docker-compose up --build`
+To start the setup, type: `docker-compose up -d --build`
 
 # demo