Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to create partitioned tables without primary key #25

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

briets
Copy link

@briets briets commented Jul 20, 2023

Often in datawarehouses there are tables that have no primary key, they rather use a unique constraint on many dimension foreign keys. TO be able to deal with these tables this PR adds the possibility to create partitioned tables without primary key.

The pkCompositeOne and pkCompositeTwo parameters are nullable but not rearranged in the method due to backwards compatibility.

@ArdaKaraderi ArdaKaraderi requested a review from denizgolbas July 25, 2023 14:12
@ArdaKaraderi ArdaKaraderi added the enhancement New feature or request label Oct 5, 2023
@ArdaKaraderi ArdaKaraderi added the needs review This issue requires a review from the maintainers. label Jan 23, 2024
@ArdaKaraderi
Copy link
Contributor

Dear Rick,

Based on the demand from the community, if you can update this with the latest changes from the repo and extend it to include List & Hash partitions, I would be happy to merge it.

@asterissco - #36

@ArdaKaraderi ArdaKaraderi requested review from ArdaKaraderi and removed request for denizgolbas June 13, 2024 17:22
Copy link
Contributor

@ArdaKaraderi ArdaKaraderi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, can you please apply the logic to the rest of the methods? (hash and list)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs review This issue requires a review from the maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants