Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest Launch4j version and removed Launch4j code #7

Merged
merged 5 commits into from
Sep 3, 2014

Conversation

taxone
Copy link
Contributor

@taxone taxone commented Sep 2, 2014

Hi,
this branch contains two main modifications.

The Launch4j source code is not included any more. Now there's an explict dependency in the pom.xml to the Launch4j artifact (I released it to Maven Central repository). So now it should be easier to manage upgrades to latest Launch4j versions.

The latest Launch4j version (3.4.0) is now used, instead of 3.0.0-pre2.

<!-- <descriptor>src/main/assembly/assemble-solaris.xml</descriptor> -->
<!-- </descriptors> -->
<!-- </configuration> -->
<!-- </execution> -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because the "workdir" jars are now stored as launch4j artifacts, take a look here:

http://search.maven.org/#browse|-241577890

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so please remove this section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thank you for noticing it.

@lukaszlenart
Copy link
Collaborator

Looks good, did or do you publish it to Maven Central? I can do it if so

@taxone
Copy link
Contributor Author

taxone commented Sep 2, 2014

Not yet.
You can do it.

lukaszlenart added a commit that referenced this pull request Sep 3, 2014
Upgrade to latest Launch4j version and removed Launch4j code
@lukaszlenart lukaszlenart merged commit b783c40 into orphan-oss:master Sep 3, 2014
@strayer
Copy link

strayer commented Sep 6, 2014

@taxone Please take a look at issue #8 - the workdir jars published to Maven Central are missing the binaries for Linux and OS X, so this pull request breaks the plugin on those platforms.

@taxone
Copy link
Contributor Author

taxone commented Sep 7, 2014

Thank you so much @strayer!!! I'm going to fix the Linux and Mac jars as soon as possible.

@lukaszlenart
Copy link
Collaborator

@taxone let me know and I will publish new version to Maven Central

@taxone
Copy link
Contributor Author

taxone commented Sep 8, 2014

@lukaszlenart I've just released on Maven Central the Launch workdir jars for Linux and MacOs. Now these jars contain also the "bin" folder and the issue opened by @strayer should be fixed:

http://repo1.maven.org/maven2/net/sf/launch4j/launch4j/3.4.0/

@lukaszlenart
Copy link
Collaborator

Thanks a lot @taxone !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants