-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to latest Launch4j version and removed Launch4j code #7
Conversation
<!-- <descriptor>src/main/assembly/assemble-solaris.xml</descriptor> --> | ||
<!-- </descriptors> --> | ||
<!-- </configuration> --> | ||
<!-- </execution> --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because the "workdir" jars are now stored as launch4j artifacts, take a look here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so please remove this section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Thank you for noticing it.
Looks good, did or do you publish it to Maven Central? I can do it if so |
Not yet. |
Upgrade to latest Launch4j version and removed Launch4j code
Thank you so much @strayer!!! I'm going to fix the Linux and Mac jars as soon as possible. |
@taxone let me know and I will publish new version to Maven Central |
@lukaszlenart I've just released on Maven Central the Launch workdir jars for Linux and MacOs. Now these jars contain also the "bin" folder and the issue opened by @strayer should be fixed: http://repo1.maven.org/maven2/net/sf/launch4j/launch4j/3.4.0/ |
Thanks a lot @taxone ! |
Hi,
this branch contains two main modifications.
The Launch4j source code is not included any more. Now there's an explict dependency in the pom.xml to the Launch4j artifact (I released it to Maven Central repository). So now it should be easier to manage upgrades to latest Launch4j versions.
The latest Launch4j version (3.4.0) is now used, instead of 3.0.0-pre2.