feat(server): allow named url shortening (#40)

[Vaelatern]

Description

I ran the filename header through the URL shortening route

Motivation and Context

This lets me use rustypaste to link to a specific link using a specified short name (for ergonomics).

Also fixes #40 by the by.

How Has This Been Tested?

Changelog Entry

### Added

- Enable naming shortened URLs beyond using a random string or the text "url"

-->

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (no code change)
• Refactor (refactoring production code)
• Other

Checklist:

• My code follows the code style of this project.
• I have updated the documentation accordingly.
• I have formatted the code with rustfmt.
• I checked the lints with clippy.
• I have added tests to cover my changes.
• All new and existing tests passed.

[tessus]

Thanks for the PR. Can you also please add test cases and fixtures?

[Vaelatern]

Sure thing! I'm trying to get in lint compliance too.

[tessus]

There are a few things to fix. The formatting checks, lints, and tests fail. These have to be fixed and new tests should be added that handle your use case.

[tessus]

Unfortunately there are still issues with this PR.

May I suggest to go through the checklist?

• cargo fmt --check --
• cargo clippy
• cargo test -- --test-threads 1
• ./fixtures/test-fixtures.sh

Currently the code does not even compile.

[Vaelatern]

I've pushed an update now, it passes CI on my own fork. I've also updated the checkboxes in the original message with what I've done.

[tessus]

Nice, this looks good. Thanks.

[tessus]

@orhun can you please have a look? I promised I would only merge dependency PRs. ;-)

@Vaelatern let's wait for orhun's approval, since he's the owner of the project. I can't merge without his ok.

[Vaelatern]

Sounds good!

I just started using this today, noticed this hole, and wanted to contribute a fix.

[Vaelatern]

Apparently I need to sign the commits too

[tessus]

why? nope, you don't. This project does not have a requirement of signed commits.

[tessus]

oops, yeah. I am sorry. this policy must be new.

[Vaelatern]

Now pushed with signed commit, both this and #374 (which I'm about to refactor a tiny bit)

[tessus]

Thanks.

P.S.: We squash the commits in a PR anyway, in which case the resulting commit would be signed, so the message under the merge button was a bit confusing and IMO wrong. It should say that all commits in the PR must be signed.

[orhun]

Good stuff 💯

Thanks!