fix(upload): error on upload with the same filename #258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently it is possible to upload files with the same name. This is undefined behavior. e.g. which file should be returned when accessing it?
To solve this problem this change introduces a check whether a file (that hasn't expired) alredy exists with the same name. If so, an error will be returned.
Motivation and Context
see #241
I am opening this PR now, because I want to check, whether the test that fails in #246 also fails with this one.
Depending on which PR is merged first, a change will be required to add an
.await
to theglob_match_file
call.How Has This Been Tested?
Changelog Entry
Types of Changes
Checklist: