fix(server): return the correct file on multiple files with same name

[tessus]

Description

The glob_match_file function returns the wrong entry. glob yields paths in alphabetical order. We want the file with the longest expiry date/time.

Motivation and Context

fixes #218

How Has This Been Tested?

• manually
• cargo test
• fixtures

Changelog Entry

### Changed

- Fixed an erroneous `file not found` occurrence

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (no code change)
• Refactor (refactoring production code)
• Other

Checklist:

• My code follows the code style of this project.
• I have updated the documentation accordingly.
• I have formatted the code with rustfmt.
• I checked the lints with clippy.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8de2450) 70.11% compared to head (5056916) 70.11%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   70.11%   70.11%           
=======================================
  Files          11       11           
  Lines         609      609           
=======================================
  Hits          427      427           
  Misses        182      182           

Flag	Coverage Δ
unit-tests	70.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[orhun]

Such an effective fix! Can you think of any edge cases that this would break backwards compatibility?

[tessus]

I thought about it for a while and it won't break anything.

But I see an issue that has nothing to do with this or the previous PRs: One can upload multiple files with the same name, but that was already possible with the curl -F "[email protected];filename=wow.nice" command when random_url was not set. This case was never taken into consideration.
We can look into this in a separate discussion or issue.

[tessus]

I created a separate discussion #241

Can you think of any edge cases that this would break backwards compatibility?

A bit more info:

If multiple files with the same name are on the server, the file with the longest expiry timestamp will be returned when accessing the file via curl <server>/file.txt

Previously a different file was returned. Which one is not entirely clear depending on expiration but not yet cleaned from disk, and so on.

But this was never a defined behavior anyway, thus no breaking change.

[orhun]

Thanks for looking into this and creating a discussion! I will get to that soon - I think this PR is in good shape to merge now.