-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): allow to override filename when using random_url #233
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 70.11% 70.88% +0.76%
==========================================
Files 11 11
Lines 609 625 +16
==========================================
+ Hits 427 443 +16
Misses 182 182
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I saw your blog post and checked out your talk about ratatui. It was great and it looked like you had a lot of fun. (I seriously enjoyed you skipping the emacs slide.) Argh, too bad I didn't get a sticker. ;-) Btw, is there still anything open for my PRs that I haven't addressed? |
Hey @tessus! Thanks for watching my talk and your comments. I highly appreciate it. I was not able to take a look at PRs but now I have some free time. Will add a review soon! Sorry for the wait. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor points 🐻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Description
Even if
random_url
is set, the filename will beoverride.txt
(the name specified in the headerfilename
).Motivation and Context
See issue #217
closes #217
How Has This Been Tested?
Changelog Entry
Types of Changes
Checklist: