perf(test): don't create regex inside a loop (#937)

orhun · Oct 29, 2024 · 0fabf22 · 0fabf22
1 parent a9b2690
commit 0fabf22
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/git-cliff-core/tests/integration_test.rs b/git-cliff-core/tests/integration_test.rs
@@ -266,18 +266,19 @@ fn generate_changelog() -> Result<()> {
 	let template = Template::new("test", changelog_config.body.unwrap(), false)?;
 
 	writeln!(out, "{}", changelog_config.header.unwrap()).unwrap();
+	let text_processors = [TextProcessor {
+		pattern:         Regex::new("<DATE>").unwrap(),
+		replace:         Some(String::from("2023")),
+		replace_command: None,
+	}];
 	for release in releases {
 		write!(
 			out,
 			"{}",
 			template.render(
 				&release,
 				Option::<HashMap<&str, String>>::None.as_ref(),
-				&[TextProcessor {
-					pattern:         Regex::new("<DATE>").unwrap(),
-					replace:         Some(String::from("2023")),
-					replace_command: None,
-				}]
+				&text_processors
 			)?
 		)
 		.unwrap();