Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): add prev/next toggle by lines #1308

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

HelloWorld017
Copy link
Member

Background

  • Typical Egg lyrics for J-POP consist of three lines: [Original Japanese / Pronunciation / Meaning]
  • Each 3 lines for previous / next lyrics (total 9 lines) are kinda 'too much'

Changes

  • Add new settings for prev / next lyrics visibility toggle
    • If average lines of lyric exceeds the value, prev / next lyrics are hidden.
    • Otherwise, prev / next lyrics are shown.

Screenshots

Three Line Lyrics Single Line Lyrics
Three Line Lyrics Single Line Lyrics

@HelloWorld017 HelloWorld017 self-assigned this Dec 2, 2024
Copy link

sonarcloud bot commented Dec 2, 2024

@JellyBrick JellyBrick added the Type: Enhancement New feature or request label Dec 2, 2024
@JellyBrick JellyBrick merged commit 4dadd5b into master Dec 2, 2024
6 checks passed
@HelloWorld017 HelloWorld017 deleted the feature/prevnext-toggle-by-lines branch December 2, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants