Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migration always fails on new config #1305

Merged
merged 1 commit into from
Dec 1, 2024
Merged

fix: migration always fails on new config #1305

merged 1 commit into from
Dec 1, 2024

Conversation

HelloWorld017
Copy link
Member

@HelloWorld017 HelloWorld017 commented Dec 1, 2024 •
edited
Loading

Background

  • When the new config is initialized, the migrator tries to migrate from 0.0.0 to latest
    1. But the config is not compatible with 0.16 config
    2. Migrator fails
    3. Setting __internal__.version fails
    4. At next startup, the migrator tries to migrate
    5. (Repeat)

Changes

  • Set __internal__.version in DEFAULT_CONFIG

Fixes

@HelloWorld017 HelloWorld017 self-assigned this Dec 1, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@JellyBrick JellyBrick merged commit a116848 into master Dec 1, 2024
6 checks passed
@HelloWorld017 HelloWorld017 deleted the fix/invalid-migration branch December 1, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JellyBrick JellyBrick JellyBrick approved these changes

@Su-Yong Su-Yong Awaiting requested review from Su-Yong

Assignees

@HelloWorld017 HelloWorld017

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

재부팅 시 테마 / 가사 초기화 문제
2 participants
@HelloWorld017 @JellyBrick