Preparing code (CS, Unit tests) for contributors #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The page for project contributors does not describe the preparation of code for submitting (in the English version at all, but in the Russian version based on PHP-CS-Fixer).
At the same time, the project itself is configured to check the code using Laravel Pint.
What is the current way to correct code style? I think it’s worth bringing both versions of the documentation to the actual approach.
I also propose to describe the launch of Unit tests.
P.S. Of course Laravel Pint is based on PHP-CS-Fixer, but PHP-CS-Fixer does not recognize the Laravel Pint configuration, so the result may not be correct.