Sort feeds from high to low (on the map)

[skanderm]

Summary by CodeRabbit

• New Features
  • Introduced a new sorting mechanism for feeds based on geographical coordinates, enhancing the display order for users.
• Improvements
  • Optimized performance by implementing memoization for feed sorting, ensuring a smoother user experience.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the FeedsPage component within ui/src/pages/listen/index.tsx. The main modification involves refactoring how feeds are retrieved and processed, transitioning from a direct assignment to using feedsQueryResult. This allows for enhanced processing, including a new sorting mechanism that organizes feeds by latitude in descending order. The rendering logic has been updated to utilize the newly sorted feeds, ensuring the component displays them correctly.

Changes

File Path	Change Summary
ui/src/pages/listen/index.tsx	Refactored FeedsPage to use feedsQueryResult for feeds retrieval; implemented sorting by latitude using useMemo; updated rendering logic to display sortedFeeds.

Possibly related PRs

• Bouts index UI #694: The changes in the BoutsPage component involve sorting and displaying feeds, which is directly related to the sorting mechanism introduced in the FeedsPage component of the main PR. Both components handle feed data and utilize similar sorting logic.

Suggested reviewers

• paulcretu

🐰 In the meadow, feeds align,
Sorted by latitude, oh so fine!
With every hop, they find their place,
A joyful dance in a digital space.
Let the data flow, let the sorting gleam,
In the world of feeds, we chase our dream! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (2)

ui/src/pages/listen/index.tsx (2)

12-12: Consider handling loading and error states.

The refactoring to store the full query result is good, but we could enhance the user experience by handling loading and error states.

 const feedsQueryResult = useFeedsQuery();
+
+if (feedsQueryResult.isLoading) {
+  return <Typography>Loading feeds...</Typography>;
+}
+
+if (feedsQueryResult.error) {
+  return <Typography color="error">Error loading feeds: {feedsQueryResult.error.message}</Typography>;
+}

---

14-19: Consider adding type safety to the sort comparison.

The sorting implementation is correct, but we can make it more type-safe by ensuring non-null values.

 const sortedFeeds = useMemo(
   () =>
-    feedsQueryResult.data?.feeds.sort((a, b) => b.latLng.lat - a.latLng.lat),
+    feedsQueryResult.data?.feeds.slice().sort((a, b) => {
+      if (!a.latLng?.lat || !b.latLng?.lat) return 0;
+      return b.latLng.lat - a.latLng.lat;
+    }),
   [feedsQueryResult.data],
 );

Note: Using slice() before sort() prevents mutating the original array.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between e34f566 and 4264d11.

📒 Files selected for processing (1)

• ui/src/pages/listen/index.tsx (2 hunks)

🔇 Additional comments (2)

ui/src/pages/listen/index.tsx (2)

4-4: LGTM!

The useMemo import is correctly added and necessary for the new sorting implementation.

---

21-21: LGTM!

The null check is correctly updated to use the new sortedFeeds variable.