Select first online feed on layout load #675
Conversation
skanderm
commented
Oct 10, 2024
skanderm
commented
- Fixes Grayed out play button is confusing to users #334
| @@ -44,6 +44,7 @@ function MapLayout({ children }: { children: ReactNode }) { | |||
| const [currentFeed, setCurrentFeed] = useState(feed); | |||
| const [map, setMap] = useState<LeafletMap>(); | |||
| const feeds = useFeedsQuery().data?.feeds ?? []; | |||
| const firstOnlineFeed = feeds.filter(({ online }) => online)[0]; | |||
There was a problem hiding this comment.
This should be fine for SSR since the query gets refetched by default (refetchOnMount is default true): https://tanstack.com/query/latest/docs/framework/react/reference/useQuery#usequery
There was a problem hiding this comment.
Yeah should be fine for SSR although it will thrash a bit (first load with no feed selected, then once this requests runs, the page will switch over to the online feed)
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
| @@ -44,6 +44,7 @@ function MapLayout({ children }: { children: ReactNode }) { | |||
| const [currentFeed, setCurrentFeed] = useState(feed); | |||
| const [map, setMap] = useState<LeafletMap>(); | |||
| const feeds = useFeedsQuery().data?.feeds ?? []; | |||
| const firstOnlineFeed = feeds.filter(({ online }) => online)[0]; | |||
There was a problem hiding this comment.
Yeah should be fine for SSR although it will thrash a bit (first load with no feed selected, then once this requests runs, the page will switch over to the online feed)
