Count supported managed DB resources. #9
Conversation
kanstantsink-orca
commented
Dec 10, 2024
•
kanstantsink-orca
commented
aws_resource_count.py
Outdated
| "dynamodb": { | ||
| "function": get_region_dynamodb_resources, | ||
| "display_name": "DynamoDB Tables", | ||
| "workload_units": 50 |
There was a problem hiding this comment.
Where does this number come from?
There was a problem hiding this comment.
we still need to confirm it. For now I put it same as Lambda functions
aws_resource_count.py
Outdated
| for db_instance in page["DBInstances"]: | ||
| db_engine = db_instance["Engine"] | ||
| db_engine_normalized = db_engine.replace("aurora-", "").replace("postgresql", "postgres") | ||
| if db_engine_normalized in supported_db_engines: |
There was a problem hiding this comment.
Should we consider size too? i.e. > 1tb
There was a problem hiding this comment.
I think it should be an option to the runner script weather to count all or under 1TB only
|
|
aws_resource_count.py
Outdated
| }, | ||
| "dynamodb": { | ||
| "function": get_region_dynamodb_resources, | ||
| "display_name": "DynamoDB Tables", |
There was a problem hiding this comment.
I think we expect same display names across providers, so we should have Managed Databases and DataWarehouses
aws_resource_count.py
Outdated
| }, | ||
| "redshift": { | ||
| "function": get_region_redshift_resources, | ||
| "display_name": "Redshift Clusters", |
There was a problem hiding this comment.
We may want to merge the count of DDB + RedShift cause I think we want one value for DataWarehouses
Change workload units for DDB to 4
|
