Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certificate handling for ATEC608B and ESP32S3 #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Certificate handling for ATEC608B and ESP32S3 #1

wants to merge 2 commits into from

Conversation

TheSciBoy
Copy link
Collaborator

@TheSciBoy TheSciBoy commented Aug 16, 2024 •
edited
Loading

Make configuration possible for ESP32S3 and add a configuration option for selecting the address during runtime.

@TheSciBoy TheSciBoy force-pushed the daniel/os-2426-cert branch from 6f16ee5 to a5ebaa7 Compare August 16, 2024 11:53
@TheSciBoy TheSciBoy marked this pull request as ready for review August 16, 2024 11:55
@TheSciBoy TheSciBoy force-pushed the daniel/os-2426-cert branch from a5ebaa7 to c12b082 Compare August 21, 2024 12:43
mickeprag
mickeprag approved these changes Aug 22, 2024
View reviewed changes
Copy link

@mickeprag mickeprag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut. Men eftersom detta är tänk att skicka upstream hade jag:

  • Inte haft med våra JIRA i commit-meddelandena
  • Inte commitat whitespace fel
  • Haft längre förklarande commit-meddelande som beskriver vad och varför vi gör ändringen.

components/esp-tls/esp_tls_mbedtls.c Outdated Show resolved Hide resolved
@TheSciBoy TheSciBoy force-pushed the daniel/os-2426-cert branch from c12b082 to ea37259 Compare August 26, 2024 11:18
@TheSciBoy TheSciBoy force-pushed the daniel/os-2426-cert branch from ea37259 to b308be3 Compare August 26, 2024 12:44
@TheSciBoy TheSciBoy requested a review from mickeprag August 26, 2024 12:46
@TheSciBoy TheSciBoy force-pushed the daniel/os-2426-cert branch from b308be3 to 50733b0 Compare August 26, 2024 12:53
@TheSciBoy TheSciBoy force-pushed the daniel/os-2426-cert branch from 50733b0 to c42d91f Compare August 26, 2024 13:17
@TheSciBoy TheSciBoy force-pushed the daniel/os-2426-cert branch from c42d91f to d10bccf Compare August 26, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickeprag mickeprag mickeprag approved these changes

@KHANyberg KHANyberg KHANyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheSciBoy @mickeprag @KHANyberg