Update push.go #1600
Open
Update push.go #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix scope action only has pull when get service token in executing cmd `org push` Signed-off-by: hopegi <[email protected]>
hopegi
requested review from
sajayantony,
shizhMSFT,
SteveLasker,
qweeah and
TerryHowe
as code owners
TerryHowe
reviewed
Dec 27, 2024
| @@ -224,7 +224,7 @@ func runPush(cmd *cobra.Command, opts *pushOptions) error { | |||
| copy := func(root ocispec.Descriptor) error { | |||
| // add both pull and push scope hints for dst repository | |||
| // to save potential push-scope token requests during copy | |||
| ctx = registryutil.WithScopeHint(ctx, dst, auth.ActionPull, auth.ActionPush) | |||
| ctx = registryutil.WithScopeHint(ctx, originalDst, auth.ActionPull, auth.ActionPush) | |||
There was a problem hiding this comment.
That is going to break the progress bar. I need to investigate more what you are trying to fix because this should work for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix scope action only has pull when get service token in executing cmd
org pushWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1599
fix this issue #1599
Please check the following list: