Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize metrics creation and add documentation #66

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Conversation

azrod
Copy link
Member

@azrod azrod commented Oct 20, 2024

No description provided.

@azrod azrod requested a review from a team as a code owner October 20, 2024 10:07
@azrod azrod force-pushed the optimize-metrics branch 2 times, most recently from 14ba1b8 to fe2ab39 Compare October 20, 2024 10:38
internal/metrics/common.go Show resolved Hide resolved
docs/advanced/metrics.md Outdated Show resolved Hide resolved
internal/metrics/admission-controller.go Outdated Show resolved Hide resolved
@azrod azrod force-pushed the optimize-metrics branch 2 times, most recently from 4387d85 to 8ae52e4 Compare October 21, 2024 14:59
@cloudavenue-bot
Copy link

Thank you for your contribution, but this PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR.
Note this PR might be rejected due to its size.

cmd/admission-controller/webhook.go Outdated Show resolved Hide resolved
internal/metrics/admission-controller.go Outdated Show resolved Hide resolved
internal/metrics/events.go Outdated Show resolved Hide resolved
internal/metrics/events.go Outdated Show resolved Hide resolved
test/metrics/metrics_test.go Show resolved Hide resolved
[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
@azrod azrod merged commit d55cd0f into main Oct 22, 2024
8 of 9 checks passed
@azrod azrod deleted the optimize-metrics branch October 22, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants