Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: enhancement metrics method #48

Merged
merged 3 commits into from
Oct 18, 2024
Merged

refactor: enhancement metrics method #48

merged 3 commits into from
Oct 18, 2024

Conversation

dmicheneau
Copy link
Member

No description provided.

@dmicheneau dmicheneau linked an issue Oct 16, 2024 that may be closed by this pull request
Enhancement: metrics method #42
Closed
@dmicheneau dmicheneau changed the title 42 enhancement metrics method refactor: enhancement metrics method Oct 16, 2024
@dmicheneau dmicheneau force-pushed the 42-enhancement-metrics-method branch 2 times, most recently from cec8f8c to da3be6d Compare October 17, 2024 13:32
@dmicheneau dmicheneau requested a review from a team as a code owner October 17, 2024 13:32
azrod
azrod reviewed Oct 17, 2024
View reviewed changes
cmd/admission-controller/webhook.go Show resolved Hide resolved
cmd/kimup/scheduler.go Outdated Show resolved Hide resolved
internal/metrics/actions.go Outdated Show resolved Hide resolved
internal/metrics/metrics.go Outdated Show resolved Hide resolved
test/metrics/metrics_test.go Outdated Show resolved Hide resolved
test/metrics/metrics_test.go Outdated Show resolved Hide resolved
test/metrics/metrics_test.go Outdated Show resolved Hide resolved
azrod
azrod reviewed Oct 18, 2024
View reviewed changes
test/metrics/metrics_test.go Outdated Show resolved Hide resolved
@dmicheneau
refactor: simplify the use of metrics
fe5ad76 
refactor: metrics names and use

refactor: simplify the use of metrics

refactor: metrics names and use

test: add unit test for metrics actions

fix: add create for mutatingwebhook

test: add unit test for counter
@dmicheneau dmicheneau force-pushed the 42-enhancement-metrics-method branch from 682c732 to fe5ad76 Compare October 18, 2024 08:26
azrod
azrod reviewed Oct 18, 2024
View reviewed changes
cmd/kimup/scheduler.go Outdated Show resolved Hide resolved
azrod
azrod reviewed Oct 18, 2024
View reviewed changes
cmd/kimup/scheduler.go Outdated Show resolved Hide resolved
azrod
azrod reviewed Oct 18, 2024
View reviewed changes
cmd/kimup/scheduler.go Outdated Show resolved Hide resolved
azrod
azrod reviewed Oct 18, 2024
View reviewed changes
cmd/kimup/scheduler.go Outdated Show resolved Hide resolved
azrod
azrod reviewed Oct 18, 2024
View reviewed changes
Copy link
Member

@azrod azrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

,

@dmicheneau dmicheneau merged commit 1f30a9c into main Oct 18, 2024
6 of 7 checks passed
@dmicheneau dmicheneau deleted the 42-enhancement-metrics-method branch October 18, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azrod azrod azrod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: metrics method
2 participants
@dmicheneau @azrod