Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rb_enc_interned_str #3706

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Implement rb_enc_interned_str #3706

merged 1 commit into from
Nov 7, 2024

Conversation

Th3-M4jor
Copy link
Contributor

closes #3703

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 3, 2024
@Th3-M4jor
Copy link
Contributor Author

On an unrelated note that might just be an issue with my local setup but bin/jt test cexts --no-gems fails with

Error during command: test cexts --no-gems
/home/spartan364/truffleruby-ws/truffleruby/tool/jt.rb:676:in `bitbucket_url': Need a git remote in truffleruby with the internal repository URL (RuntimeError)
        from /home/spartan364/truffleruby-ws/truffleruby/tool/jt.rb:1755:in `gem_test_pack'
        from /home/spartan364/truffleruby-ws/truffleruby/tool/jt.rb:1512:in `block in run_single_cexts_test'
        from /home/spartan364/truffleruby-ws/truffleruby/tool/jt.rb:1583:in `time_test'
        from /home/spartan364/truffleruby-ws/truffleruby/tool/jt.rb:1469:in `run_single_cexts_test'
        from /home/spartan364/truffleruby-ws/truffleruby/tool/jt.rb:1461:in `block in test_cexts'
        from /home/spartan364/truffleruby-ws/truffleruby/tool/jt.rb:1460:in `each'
        from /home/spartan364/truffleruby-ws/truffleruby/tool/jt.rb:1460:in `test_cexts'
        from /home/spartan364/truffleruby-ws/truffleruby/tool/jt.rb:1189:in `test'
        from /home/spartan364/truffleruby-ws/truffleruby/tool/jt.rb:3275:in `main'
        from /home/spartan364/truffleruby-ws/truffleruby/tool/jt.rb:3284:in `<main>'

andrykonchin
andrykonchin approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@andrykonchin andrykonchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Could you please squash commits into a single one?

CHANGELOG.md Outdated Show resolved Hide resolved
@andrykonchin
Copy link
Member

On an unrelated note that might just be an issue with my local setup but bin/jt test cexts --no-gems fails with

Yeah, it seems a bug. Thank you for reporting!

@Th3-M4jor Th3-M4jor force-pushed the implement-rb_enc_interned_str-cext-function branch from ebeb4a5 to f6c0fec Compare November 6, 2024 23:09
@Th3-M4jor
Copy link
Contributor Author

I've squashed the commits and fixed the changelog entry to point to the issue instead of the PR

@andrykonchin andrykonchin self-assigned this Nov 7, 2024
@andrykonchin andrykonchin added the in-ci The PR is being tested in CI. Do not push new commits. label Nov 7, 2024
@andrykonchin andrykonchin force-pushed the implement-rb_enc_interned_str-cext-function branch from f6c0fec to ee9b6cb Compare November 7, 2024 14:18
@graalvmbot graalvmbot merged commit a4e5318 into oracle:master Nov 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon left review comments

@andrykonchin andrykonchin andrykonchin approved these changes

Assignees

@andrykonchin andrykonchin

Labels
in-ci The PR is being tested in CI. Do not push new commits. OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
24.2.0 Release (March 18, 2025)
Development

Successfully merging this pull request may close these issues.

rb_enc_interned_str() not yet implemented
4 participants
@Th3-M4jor @andrykonchin @eregon @graalvmbot