Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test and metadata locations for iText Core modules and iText add-ons #588

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

vitali-pr
Copy link
Contributor

What does this PR do?

This PR updates test and metadata locations for iText Core modules and adds iText pdfHtml to the list of tested libraries and frameworks.

Code sections where the PR accesses files, network, docker or some external service

Checklist before merging

@vitali-pr vitali-pr requested a review from fniephaus as a code owner January 16, 2025 12:17
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the updates!

@fniephaus
Copy link
Member

The check probably failed because the entries are not in order. Could you please make sure they are sorted alphabetically by artifact name?

@vitali-pr
Copy link
Contributor Author

The check probably failed because the entries are not in order. Could you please make sure they are sorted alphabetically by artifact name?

I've checked and they are sorted. There was 1 extra newline comparing to 'jq -s '.[] | sort_by(.artifact)' ./library-and-framework-list.json' result. Could it be the reason? Removed it.

@fniephaus fniephaus merged commit e130076 into oracle:master Jan 16, 2025
5 checks passed
@fniephaus
Copy link
Member

Could it be the reason? Removed it

Looks like it. Thanks for fixing!

@vitali-pr vitali-pr deleted the itextpdf branch January 16, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants