-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add create vnic details #205
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Jan 24, 2023
|
joekr
force-pushed
the
add-createVnicDetails
branch
2 times, most recently
from
January 24, 2023 01:53
63da13f
to
c34cce7
Compare
joekr
commented
Jan 24, 2023
joekr
force-pushed
the
add-createVnicDetails
branch
from
January 24, 2023 02:34
c34cce7
to
d8e7ec8
Compare
joekr
force-pushed
the
add-createVnicDetails
branch
4 times, most recently
from
January 25, 2023 01:32
96492af
to
0548bec
Compare
joekr
force-pushed
the
add-createVnicDetails
branch
from
January 25, 2023 13:41
0548bec
to
7d7b874
Compare
unit tests
e2e testsRunning the news
I ran the PRBlocking tests but not sure what images to use for the
|
joekr
force-pushed
the
add-createVnicDetails
branch
from
January 25, 2023 13:53
7d7b874
to
c659638
Compare
joekr
commented
Jan 25, 2023
joekr
force-pushed
the
add-createVnicDetails
branch
from
January 26, 2023 17:15
c659638
to
4e9a087
Compare
joekr
force-pushed
the
add-createVnicDetails
branch
2 times, most recently
from
January 31, 2023 14:00
10990bc
to
f20810c
Compare
shyamradhakrishnan
previously approved these changes
Jan 31, 2023
joekr
force-pushed
the
add-createVnicDetails
branch
2 times, most recently
from
February 2, 2023 20:59
8905435
to
a7e3567
Compare
After removing the windows template and e2e tests I reran the tests all passed except |
joekr
force-pushed
the
add-createVnicDetails
branch
from
February 2, 2023 23:06
a7e3567
to
825ef8a
Compare
shyamradhakrishnan
previously approved these changes
Feb 3, 2023
This allows users to define vnic attachments. The reconciler will then attach them after the instance is launched.
joekr
force-pushed
the
add-createVnicDetails
branch
from
February 3, 2023 13:50
825ef8a
to
4cbbb84
Compare
shyamradhakrishnan
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add support for Windows. Windows on OCI requires Bare Metal currently. For Hyper-V to work on Bare Metal the second nic has to work, hence adding support for the second vnic.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #