Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create vnic details #205

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Add create vnic details #205

merged 1 commit into from
Feb 3, 2023

Conversation

joekr
Copy link
Member

@joekr joekr commented Jan 24, 2023

What this PR does / why we need it:
Add support for Windows. Windows on OCI requires Bare Metal currently. For Hyper-V to work on Bare Metal the second nic has to work, hence adding support for the second vnic.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@joekr joekr added the enhancement New feature or request label Jan 24, 2023
@joekr joekr self-assigned this Jan 24, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 24, 2023
@joekr
Copy link
Member Author

joekr commented Jan 24, 2023

  • Squash and rebase commits before merging.

@joekr joekr force-pushed the add-createVnicDetails branch 2 times, most recently from 63da13f to c34cce7 Compare January 24, 2023 01:53
cloud/scope/vnic_reconciler.go Outdated Show resolved Hide resolved
@joekr joekr force-pushed the add-createVnicDetails branch from c34cce7 to d8e7ec8 Compare January 24, 2023 02:34
@joekr joekr mentioned this pull request Jan 24, 2023
@joekr joekr force-pushed the add-createVnicDetails branch 4 times, most recently from 96492af to 0548bec Compare January 25, 2023 01:32
@joekr joekr force-pushed the add-createVnicDetails branch from 0548bec to 7d7b874 Compare January 25, 2023 13:41
@joekr
Copy link
Member Author

joekr commented Jan 25, 2023

unit tests

?       github.com/oracle/cluster-api-provider-oci      [no test files]
ok      github.com/oracle/cluster-api-provider-oci/api/v1beta1  0.275s  coverage: 17.6% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/config [no test files]
ok      github.com/oracle/cluster-api-provider-oci/cloud/ociutil        0.546s  coverage: 25.0% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/scope  166.030s        coverage: 76.5% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks    [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/base  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/base/mock_base        [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute       [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement     [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement/mock_computemanagement      [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine       [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine/mock_containerengine  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity      [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity        [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn  [no test files]
ok      github.com/oracle/cluster-api-provider-oci/controllers  26.702s coverage: 67.7% of statements
ok      github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1      0.475s  coverage: 8.8% of statements
ok      github.com/oracle/cluster-api-provider-oci/exp/controllers      1.353s  coverage: 55.3% of statements
?       github.com/oracle/cluster-api-provider-oci/feature      [no test files]
?       github.com/oracle/cluster-api-provider-oci/version      [no test files]

e2e tests

Running the news windows test. It isn't part of the [PR blocking] tests

GINKGO_FOCUS="Windows - With 1 Linux control-plane nodes and with 1 Windows worker nodes" scripts/ci-e2e.sh
...
...
...
Ran 1 of 22 Specs in 1799.116 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 21 Skipped

I ran the PRBlocking tests but not sure what images to use for the OCI_MANAGED_NODE_IMAGE_ID yet.

Summarizing 1 Failure:
  [FAIL] Managed Workload cluster creation [It] Managed Cluster - Simple [PRBlocking]
  /home/ubuntu/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/clusterctl/client.go:302

Ran 6 of 23 Specs in 2051.882 seconds
FAIL! -- 5 Passed | 1 Failed | 0 Pending | 17 Skipped

@joekr joekr force-pushed the add-createVnicDetails branch from 7d7b874 to c659638 Compare January 25, 2023 13:53
scripts/ci-e2e.sh Outdated Show resolved Hide resolved
@joekr joekr force-pushed the add-createVnicDetails branch from c659638 to 4e9a087 Compare January 26, 2023 17:15
@joekr joekr marked this pull request as ready for review January 28, 2023 03:47
@joekr joekr force-pushed the add-createVnicDetails branch 2 times, most recently from 10990bc to f20810c Compare January 31, 2023 14:00
@joekr joekr force-pushed the add-createVnicDetails branch 2 times, most recently from 8905435 to a7e3567 Compare February 2, 2023 20:59
@joekr
Copy link
Member Author

joekr commented Feb 2, 2023

After removing the windows template and e2e tests I reran the tests all passed except managed cluster but I think that is a setup issue on my end.

@joekr joekr force-pushed the add-createVnicDetails branch from a7e3567 to 825ef8a Compare February 2, 2023 23:06
This allows users to define vnic attachments. The reconciler
will then attach them after the instance is launched.
@joekr joekr merged commit 95aa2c6 into oracle:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants