Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework for Tabstrip regression issue #4871

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

leigh-pointer
Copy link
Contributor

Fix for TabPanel is not updating the UI. #4778 #4828

@sbwalker
Copy link
Member

@leigh-pointer there are a lot of third party modules which use the TabStrip component... I am concerned that these recent changes will result in regression issues / broken functionality.

@sbwalker
Copy link
Member

After more testing (without applying #4871) there are also UX issues with adding new pages and editing existing pages. I am going to rollback #4828 as there are too many ripple effects to this change.

@leigh-pointer
Copy link
Contributor Author

@sbwalker i have been extremely careful about backward compatibility. I have tested with the framework and external modules.

@sbwalker
Copy link
Member

@leigh-pointer if you select Add Page from the Control Panel and then select to change the Parent field to a different page, all of the fields on the Settings tab disappear. Do you see this issue as well?

@leigh-pointer
Copy link
Contributor Author

@sbwalker no, everything works fine.

@sbwalker sbwalker merged commit a499cfb into oqtane:dev Nov 26, 2024
1 check passed
@sbwalker
Copy link
Member

after applying this PR... if you select Add Page from the Control Panel and then select to change the Parent field to a different page, the Settings tab is no longer highlighted:

image

@leigh-pointer leigh-pointer deleted the HTMLTabError branch November 26, 2024 16:48
@sbwalker
Copy link
Member

#4872 also seems to have been caused by the recent changes to the TabStrip component.

@sbwalker
Copy link
Member

@leigh-pointer I rolled back #4871 and #4828 as there are too many regression problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants