-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework for Tabstrip regression issue #4871
Conversation
Fix for Tabpanel is not updating the UI. oqtane#4778 oqtane#4828
@leigh-pointer there are a lot of third party modules which use the TabStrip component... I am concerned that these recent changes will result in regression issues / broken functionality. |
@sbwalker i have been extremely careful about backward compatibility. I have tested with the framework and external modules. |
@leigh-pointer if you select Add Page from the Control Panel and then select to change the Parent field to a different page, all of the fields on the Settings tab disappear. Do you see this issue as well? |
@sbwalker no, everything works fine. |
#4872 also seems to have been caused by the recent changes to the TabStrip component. |
@leigh-pointer I rolled back #4871 and #4828 as there are too many regression problems |
Fix for TabPanel is not updating the UI. #4778 #4828