Skip to content

Commit

Permalink
Keep less secrets
Browse files Browse the repository at this point in the history
Make app & installation id public: they're like a name, which it only
used to identify. The corresponding authentication happens via JWT
(using a private key), and that is NOT public.
  • Loading branch information
opwvhk committed Mar 22, 2024
1 parent 9e22bf2 commit 49e0dc6
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@
.gradle
build
# Plugin specific
github.properties
*.pem
*.der
4 changes: 4 additions & 0 deletions src/main/resources/META-INF/github.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# suppress inspection "UnusedProperty" for whole file
key_file=avro-support-error-reporter.2024-03-21.private-key.der
app_id=860262
inst_id=48720420
4 changes: 0 additions & 4 deletions src/main/resources/META-INF/github.sample.properties

This file was deleted.

0 comments on commit 49e0dc6

Please sign in to comment.