Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to external modules #198

Merged
merged 6 commits into from
Jan 29, 2025
Merged

Conversation

nzw0301
Copy link
Member

@nzw0301 nzw0301 commented Jan 25, 2025

Motivation

Better documentation links

Description of the changes

  • A few classes/methods can be linked into third-party docs such as pytorch.
  • Add optuna docs page to intersphinx_mapping to link to optuna/optuna pages.

@nzw0301 nzw0301 added the document Documentation related. label Jan 25, 2025
@nabenabe0928 nabenabe0928 self-assigned this Jan 27, 2025
nzw0301 and others added 2 commits January 27, 2025 17:05
@nzw0301
Copy link
Member Author

nzw0301 commented Jan 27, 2025

Thanks!

Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates!
I found the very last minor change needed.

Here is the doc for torch.device.

@nzw0301
Copy link
Member Author

nzw0301 commented Jan 29, 2025

Thank you for your comments. I've updated torch.device too.

@nabenabe0928 nabenabe0928 merged commit fcbe223 into optuna:main Jan 29, 2025
65 checks passed
@nzw0301 nzw0301 deleted the link-to-optuna-docs branch January 30, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants