Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-10765] enhancement: Implement UPS request batching for decideForKeys #353

Merged
merged 19 commits into from
Jan 9, 2025
Merged

[FSSDK-10765] enhancement: Implement UPS request batching for decideForKeys #353

merged 19 commits into from
Jan 9, 2025

Conversation

FarhanAnjum-opti
Copy link
Contributor

@FarhanAnjum-opti FarhanAnjum-opti commented Dec 9, 2024 •
edited
Loading

Summary

  • Currently, decideForKeys loops over the list of flags and calls decide for each, which in turn calls ups. So for decideForKeys, there is two calls per flag to UPS. This PR batches UPS calls when using decideForKeys.

Test plan

  • Existing tests are updated to work with the new change. New tests will be added for batching.

Issues

@FarhanAnjum-opti
user profile tracker created
fc1c696
@FarhanAnjum-opti
lib/optimizely.rb -> Added user_profile_tracker require
454fd52 
lib/optimizely.rb -> Updated decide_for_keys method
lib/optimizely.rb -> Enhanced decision-making logic
lib/optimizely.rb -> Integrated UserProfileTracker usage
lib/optimizely.rb -> Refined decision reasons handling
lib/optimizely/user_profile_tracker.rb -> New user profile tracker class
@FarhanAnjum-opti
Implementation complete. Unit Tests are failing.
0f5040b
@FarhanAnjum-opti
lib/optimizely.rb -> Made optional parameter explicit
0e53504 
lib/optimizely/decision_service.rb -> Added user profile tracker usage
lib/optimizely/decision_service.rb -> Clarified handling of user profiles
lib/optimizely/user_profile_tracker.rb -> Fixed user ID reference in error
spec/decision_service_spec.rb -> Adjusted tests for user profile tracker
@FarhanAnjum-opti
lib/optimizely/decision_service.rb -> Simplified decision logging
061f8bc 
lib/optimizely/user_profile_tracker.rb -> Improved user profile lookup handling
spec/project_spec.rb -> Updated mocks for decision service calls
@FarhanAnjum-opti
lib/optimizely/decision_service.rb -> Removed user profile tracker in…
7cd21e7 
…stantiation.

lib/optimizely/user_profile_tracker.rb -> Improved error logging message.
spec/decision_service_spec.rb -> Refactored user profile tracking in tests.
spec/project_spec.rb -> Updated decision service method stubs.
spec/user_profile_tracker.rb -> Updated lookup, update and save tests for user_profile_tracker
@FarhanAnjum-opti
spec/user_profile_tracker_spec.rb -> Updated error messages in tests.
4379127
@FarhanAnjum-opti FarhanAnjum-opti requested a review from a team as a code owner December 9, 2024 13:06
Mat001
Mat001 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FarhanAnjum-opti FarhanAnjum-opti merged commit 69b2453 into master Jan 9, 2025
9 checks passed
@FarhanAnjum-opti FarhanAnjum-opti deleted the farhan/FSSDK-10765-batch-UPS branch January 9, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 approved these changes

Assignees

@FarhanAnjum-opti FarhanAnjum-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FarhanAnjum-opti @Mat001