Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9839] fix: rendering default OptimizelyVariation when not last #226

Merged
merged 4 commits into from
Dec 6, 2023
Merged

[FSSDK-9839] fix: rendering default OptimizelyVariation when not last #226

merged 4 commits into from
Dec 6, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

Summary

Test plan

  • Added new tests for coverage
  • All existing unit and e2e tests are still expected to pass

Issues

  • FSSDK-9839

@mikechu-optimizely
fix: rendering default with matching variation
adb3fe3 
OptimizelyExperiment renders `default` when before matching variations
@mikechu-optimizely
test: add coverage for default selection
cdbda16
@mikechu-optimizely mikechu-optimizely added the bug Something isn't working label Dec 5, 2023
@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review December 5, 2023 20:02
raju-opti
raju-opti approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@mikechu-optimizely mikechu-optimizely merged commit 0d4eb59 into master Dec 6, 2023
4 checks passed
@mikechu-optimizely mikechu-optimizely deleted the mike/variation-order-with-default branch December 6, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raju-opti raju-opti raju-opti approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikechu-optimizely @raju-opti